Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181

dependabot · 2023-04-01T11:58:25Z

Updates the requirements on pytorch-lightning to permit the latest version.

Release notes

Sourced from pytorch-lightning's releases.

2.0.1 patch release

App

No changes

Fabric

Changed

Generalized Optimizer validation to accommodate both FSDP 1.x and 2.x (#16733)

PyTorch

Changed

Pickling the LightningModule no longer pickles the Trainer (#17133)

Generalized Optimizer validation to accommodate both FSDP 1.x and 2.x (#16733)

Disable torch.inference_mode with torch.compile in PyTorch 2.0 (#17215)

Fixed

Fixed issue where pickling the module instance would fail with a DataLoader error (#17130)

Fixed WandbLogger not showing "best" aliases for model checkpoints when ModelCheckpoint(save_top_k>0) is used (#17121)

Fixed the availability check for rich that prevented Lightning to be imported in Google Colab (#17156)

Fixed parsing the precision config for inference in DeepSpeedStrategy (#16973)

Fixed issue where torch.compile would fail when logging to WandB (#17216)

Contributors

@Borda @williamFalcon @lightningforever @adamjstewart @carmocca @tshu-w @saryazdi @parambharat @awaelchli @colehawkins @woqidaideshi @md-121 @yhl48 @gkroiz @idc9 @speediedan

If we forgot someone due to not matching commit email with GitHub account, let us know :]

Commits

06032e8 Update app CHANGELOG
93d21ed Simplify rank_zero_experiment for torch.compile support (#17216)
7c65eee Drop pre-commit from /requirements (#17049)
637ac4b Avoid inference_mode with torch.compile (#17215)
a46b2b1 Skip length checks for non-sized iterables (#17218)
9a97fcc Generalize Optimizer validation to accommodate both FSDP 1.x and 2.x (#16733)
6336d6a ci/docs: wheels from cache (#17201)
56b4dfd ci: fix docs with caches (#17200)
966c53b Fix *_batch_end typos (#17188)
ebe97f8 fix typo in docs migration 1_6_regular (#17186)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

📚 Documentation preview 📚: https://pytorch-tabular--181.org.readthedocs.build/en/181/

> **Note**

Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version. - [Release notes](https://github.com/Lightning-AI/lightning/releases) - [Commits](Lightning-AI/pytorch-lightning@1.8.0rc0...2.0.1) --- updated-dependencies: - dependency-name: pytorch-lightning dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Borda

let's try this pinning @manujosephv 🐰

requirements.txt

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

manujosephv · 2023-05-06T02:39:01Z

@Borda Does the new version not have lightning_lite?

I'm using a function here from lightning_lite.utilities.cloud_io import get_filesystem for some loading and saving purposes and that is causing the error.

Borda · 2023-05-06T06:21:22Z

Does the new version not have lightning_lite?

Since 1.9 it is named lightning_fabric

src/pytorch_tabular/tabular_model.py

src/pytorch_tabular/utils.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

for more information, see https://pre-commit.ci

manujosephv · 2023-05-10T13:41:48Z

@Borda Some of the test case are still failing at the import lightning_fabric

src/pytorch_tabular/tabular_model.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

for more information, see https://pre-commit.ci

src/pytorch_tabular/utils.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

manujosephv · 2023-05-11T01:18:21Z

@Borda Still failing. And its only on Ubunutu 20.04. Can't see the detailed logs for some reason. But previous fails were because of the new import. Can it be possible that in Ubuntu 20.04, 1.9 is not getting installed?

dependabot · 2023-05-31T01:47:23Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2023

dependabot bot requested a review from manujosephv April 1, 2023 11:58

dependabot bot mentioned this pull request Apr 1, 2023

Update pytorch-lightning requirement from ==1.8.* to ==1.9.* #171

Closed

Borda approved these changes May 5, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

manujosephv and others added 2 commits May 6, 2023 06:42

Update requirements.txt

f2dc81a

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Merge branch 'main' into dependabot-pip-pytorch-lightning-eq-2.0.star

d40e52e

replaced lightning_lite with lightning_fabric

495da01

Borda reviewed May 10, 2023

View reviewed changes

src/pytorch_tabular/tabular_model.py Outdated Show resolved Hide resolved

Borda reviewed May 10, 2023

View reviewed changes

src/pytorch_tabular/utils.py Outdated Show resolved Hide resolved

manujosephv and others added 4 commits May 10, 2023 18:26

Merge branch 'main' into dependabot-pip-pytorch-lightning-eq-2.0.star

73c65c2

Update src/pytorch_tabular/tabular_model.py

8bf4bcc

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

0072440

for more information, see https://pre-commit.ci

Merge branch 'main' into dependabot-pip-pytorch-lightning-eq-2.0.star

5f3abe4

Borda reviewed May 10, 2023

View reviewed changes

src/pytorch_tabular/tabular_model.py Outdated Show resolved Hide resolved

manujosephv and others added 2 commits May 10, 2023 19:41

Update src/pytorch_tabular/tabular_model.py

bd103c5

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

d6a9fb8

for more information, see https://pre-commit.ci

Borda reviewed May 10, 2023

View reviewed changes

src/pytorch_tabular/utils.py Outdated Show resolved Hide resolved

Update src/pytorch_tabular/utils.py

7c50636

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Merge branch 'main' into dependabot-pip-pytorch-lightning-eq-2.0.star

2117b3f

Borda mentioned this pull request May 29, 2023

bump PL to <2.0 #223

Merged

manujosephv closed this in #223 May 31, 2023

dependabot bot deleted the dependabot-pip-pytorch-lightning-eq-2.0.star branch May 31, 2023 01:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181

Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181

Uh oh!

dependabot bot commented on behalf of github Apr 1, 2023 •

edited

Loading

Uh oh!

Borda left a comment

Uh oh!

Uh oh!

manujosephv commented May 6, 2023

Uh oh!

Borda commented May 6, 2023

Uh oh!

Uh oh!

Uh oh!

manujosephv commented May 10, 2023

Uh oh!

Uh oh!

Uh oh!

manujosephv commented May 11, 2023

Uh oh!

dependabot bot commented on behalf of github May 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181

Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181

Uh oh!

Conversation

dependabot bot commented on behalf of github Apr 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2.0.1 patch release

App

Fabric

Changed

PyTorch

Changed

Fixed

Contributors

Uh oh!

Borda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

manujosephv commented May 6, 2023

Uh oh!

Borda commented May 6, 2023

Uh oh!

Uh oh!

Uh oh!

manujosephv commented May 10, 2023

Uh oh!

Uh oh!

Uh oh!

manujosephv commented May 11, 2023

Uh oh!

dependabot bot commented on behalf of github May 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dependabot bot commented on behalf of github Apr 1, 2023 •

edited

Loading